Skip to content

fix: add maximum length validation for link titles #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshitabansal123 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add maximum length validation for link titles #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/admin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ <h2 class="modal-title" id="modalTitle">Add Link</h2>
</div>
<div class="form-group">
<label class="form-label">Title</label>
<input class="form-input" type="text" id="modalLinkTitle" placeholder="🚀 My Awesome Link">
<input class="form-input" type="text" id="modalLinkTitle" placeholder="🚀 My Awesome Link" maxlength="100">
</div>
<div class="form-group">
<label class="form-label">URL</label>
Expand Down
18 changes: 15 additions & 3 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,12 @@ app.post('/api/links', requireAuth, async (req, res) => {
return res.status(400).json({ error: 'End date must be after start date.' });
}

// Validate title length
const title = (req.body.title || 'New Link').trim();
if (title.length > 100) {
return res.status(400).json({ error: 'Link title must be 100 characters or fewer.' });
}

// Handle category assignment
let categoryId = req.body.category_id ?? null;
if (categoryId === 'uncategorized' || categoryId === '') categoryId = null;
Expand All @@ -1024,7 +1030,7 @@ app.post('/api/links', requireAuth, async (req, res) => {
const { error } = await supabase.from('user_links').insert({
id: newLinkId,
user_id: req.auth.userId,
title: req.body.title || 'New Link',
title,
url: req.body.url || 'https://',
icon: req.body.icon || 'link',
clicks: 0,
Expand All @@ -1044,7 +1050,7 @@ app.post('/api/links', requireAuth, async (req, res) => {

res.status(201).json({
id: newLinkId,
title: req.body.title || 'New Link',
title,
url: req.body.url || 'https://',
icon: req.body.icon || 'link',
clicks: 0,
Expand Down Expand Up @@ -1141,7 +1147,13 @@ app.put('/api/links/:id', requireAuth, async (req, res) => {
if (!existing) return res.status(404).json({ error: 'Link not found' });

const updates = {};
if (req.body.title !== undefined) updates.title = req.body.title;
if (req.body.title !== undefined) {
const title = req.body.title.trim();
if (title.length > 100) {
return res.status(400).json({ error: 'Link title must be 100 characters or fewer.' });
}
updates.title = title;
}
if (req.body.url !== undefined) updates.url = req.body.url;
if (req.body.icon !== undefined) updates.icon = req.body.icon;
if (req.body.active !== undefined) updates.active = req.body.active;
Expand Down