Skip to content

docs: reconcile .agents knowledge base with merged VCR harness#334

Merged
maximn merged 1 commit into
masterfrom
maximn/review-workspace-changes
Jun 30, 2026
Merged

docs: reconcile .agents knowledge base with merged VCR harness#334
maximn merged 1 commit into
masterfrom
maximn/review-workspace-changes

Conversation

@maximn

@maximn maximn commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

Reconciles the .agents/ agent knowledge base with the VCR record/replay harness that already merged in #306, so the docs stop describing the removed pre-VCR behavior. Docs-only; no code changes.

Related issue

Refs #300

Changes

  • .agents/README.md: the "fast facts" bullet now states integration tests default to VCR replay (offline, no GOOGLE_API_KEY, no charges); only the opt-in record/auto/live modes need a real key.
  • .agents/known-issues.md: rewrote B9 from "no VCR exists (deliberate tradeoff)" to the actual residual — the harness exists but no cassettes are committed yet, so replay is dormant until the dataset is recorded.

Test plan

  • Docs-only change, no code affected. Verified via grep that no stale "live API / no cassette" claims remain in .agents/ and that the remaining B9 references (known-issues.md + the testing.md breadcrumb) are consistent.

Checklist

  • dotnet format has been run. — n/a (docs only)
  • dotnet test passes locally (with a valid GOOGLE_API_KEY for integration tests). — n/a (docs only)
  • Multi-framework build passes (netstandard2.0, net8.0, net10.0). — n/a (docs only)
  • XML documentation updated if public API surface changed. — n/a (no public API change)

The VCR record/replay harness landed in #306, but two .agents docs still
described the pre-VCR world:

- README.md fast-fact: integration tests now default to VCR replay
  (offline, no key); only the opt-in record/auto/live modes need a real key.
- known-issues.md B9: rewritten from "no VCR exists (deliberate tradeoff)"
  to the real residual — the harness exists but no cassettes are committed
  yet, so replay is dormant; record + commit the dataset to finish (#300).
@github-actions

Copy link
Copy Markdown

🔬 TestGlance

✅ 262 passed across 1 job — 100.0% · ⏱️ 2.0s

Job Result Pass rate Duration Health
build 262/262 · 100.0% 2.0s Report
🟡 build — details

✅ 262 passed
████████████████ 100.0%
⏱️ 2.0s

vs master

Metric master PR Delta
Pass rate 100.0% 100.0% +0.0%
Duration 2.4s 2.0s -15.2%

📄 HTML Report


Updated 2026-06-30T21:29:38.765Z

@maximn maximn merged commit 5284332 into master Jun 30, 2026
7 checks passed
@maximn maximn deleted the maximn/review-workspace-changes branch June 30, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant