Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript/tooling configuration and dependency set, alongside a small TypeScript typing adjustment in DTOs, to keep the project building cleanly and generating docs consistently.
Changes:
- Update TypeDoc configuration to use
tsconfig.build.json, exclude spec files, and adjust external symbol link mappings. - Adjust
tsconfig.jsoncompiler options (deprecation handling,rootDir, and path/baseUrl-related settings). - Bump multiple runtime/dev dependencies (NestJS, TypeScript, ESLint ecosystem, etc.) and update DTO properties to use definite assignment assertions.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| typedoc.json | Points TypeDoc at the build tsconfig, excludes specs, and updates external symbol link mappings. |
| tsconfig.json | Updates compiler options (notably ignoreDeprecations, rootDir, and path resolution configuration). |
| src/tasks/signing/signing.dto.ts | Switches DTO fields to definite assignment assertions (!) for TS property initialization behavior. |
| src/tasks/key-generation/key-generation.dto.ts | Switches DTO fields to definite assignment assertions (!) for TS property initialization behavior. |
| package.json | Upgrades various dependencies/devDependencies including TypeScript and lint/test tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "externalSymbolLinkMappings": { | ||
| "@types/node": { | ||
| "\"crypto\".timingSafeEqual": "#" | ||
| "\"node:crypto\".timingSafeEqual": "#" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.