Open
Conversation
|
Great job, tanerincode! I hope Maksym finds time to approve it :) |
constantinosergiou
approved these changes
Apr 21, 2023
|
@maxbanton please approve this PR if it's okay for you |
|
I'm switching to another CloudWatch logging provider as this is blocking my upgrade to Laravel 10. I'm sure I'm not alone 😞 |
|
@maxbanton can you please merge this PR and make new release version? |
|
@maxbanton Please, do you have any update to merge this PR? |
Author
|
@jandominikair i think he is not available for review this pr, someone did this package alternative with this fix, you can find that one in pr's or issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[BUG] - Declaration of Maxbanton\Cwh\Handler\CloudWatch::write(array $record)... #116
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Monologue has made a significant change, it now accepts LogRecords instead of arrays. This PR contains minor changes for the given situation.