EXPERIMENTAL Implement G2/G3 arc fitting for G-code generation#66
Draft
max-scopp wants to merge 1 commit into
Draft
EXPERIMENTAL Implement G2/G3 arc fitting for G-code generation#66max-scopp wants to merge 1 commit into
max-scopp wants to merge 1 commit into
Conversation
max-scopp
commented
May 1, 2026
Owner
- Added arc fitting functionality to convert sequences of G1 moves into G2/G3 arcs, improving G-code efficiency and motion smoothness.
- Introduced new parameters for arc fitting in SlicingParams, including enabling/disabling arc fitting, tolerance, minimum segments, and maximum radius.
- Updated GcodeLayerBuffer to store geometric kinds of blocks (line or arc).
- Enhanced the Gcode layer renderer to handle arc meshes and render them appropriately.
- Created a new module for arc fitting logic, including algorithms for detecting arcs and calculating their properties.
- Added tests to ensure the arc fitting functionality behaves as expected, covering various edge cases and scenarios.
- Added arc fitting functionality to convert sequences of G1 moves into G2/G3 arcs, improving G-code efficiency and motion smoothness. - Introduced new parameters for arc fitting in SlicingParams, including enabling/disabling arc fitting, tolerance, minimum segments, and maximum radius. - Updated GcodeLayerBuffer to store geometric kinds of blocks (line or arc). - Enhanced the Gcode layer renderer to handle arc meshes and render them appropriately. - Created a new module for arc fitting logic, including algorithms for detecting arcs and calculating their properties. - Added tests to ensure the arc fitting functionality behaves as expected, covering various edge cases and scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.