Report the server as nasbridge, not truenas-mcp - #3
Merged
Conversation
serverInfo.name still carried the upstream fork's name, so clients displayed truenas-mcp for a package called nasbridge. Only the server identity changed. The callable surface is untouched on purpose: the tool is still `truenas`, the resource URIs are still `truenas://…`, and the escape hatch is still `truenas_api_call`. Those name what the server talks to, not what the server is, and renaming them would break every client that has referenced one. Also dropped "SCALE" from the two description strings — the README targets TrueNAS 26 and uses the term nowhere else. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serverInfo.namestill carried the upstream fork's name, so an MCP client handshaking with this package displayedtruenas-mcp.What deliberately did not change
The callable surface is untouched. Renaming any of it would break every client that has already referenced one:
truenastruenas://…(24 of them)truenas_api_call, whichregistry.ts:176dispatches on by exact stringThose name what the server talks to, not what the server is.
nasbridgeis the bridge; TrueNAS is what's on the far side — the split is coherent rather than an inconsistency to tidy away.Also
Dropped "SCALE" from the two description strings. The README targets TrueNAS 26 and uses the term nowhere, so it was internally inconsistent.
Verification
47/47 tests, clean build, and a real
initialize+tools/listhandshake through the live MCP wrapper:serverInfo.namereportsnasbridge, andtools/liststill returnstruenas.