Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ REST on `:8400`, browser UI on `:8405`. The UI serves only a setup page until yo
run `gateway ui set-password`.

```bash
npm test # 500+ tests, ~7s
npm test # 469 tests, ~7s
npm run build # tsc, then copies the UI assets into dist
```

Expand Down
14 changes: 14 additions & 0 deletions DECISIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ Why things are the way they are. Newest first.
Operational entries about the private deployment this was extracted from have
been left out. What remains is the reasoning that shaped the code.

## The README states the real test count

The Testing section claimed "500+ tests". `npm test` reports 469.

That is a bad claim to round up in this particular README, which spends most of
its length being careful about what CipherGate is not: no HA, no dynamic
secrets, no PKI or SSO and a pointer to Vault or OpenBao for anyone who needs
them. It is also the cheapest claim in the file to check. A reader who runs one
command, finds the number padded and then re-reads the disclaimers has been
given a reason to discount the part that is actually worth trusting.

The number is now exact, in README and AGENTS.md both. It will drift low as
tests are added, which is the safe direction for it to drift.

## Never gate authentication on a raw URL string

A pre-landing review of the browser UI found an authentication bypass that every
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ it is the highest-value surface in the system.
npm test
```

500+ tests. They cover the encryption round-trip, consumer authorization, the
469 tests. They cover the encryption round-trip, consumer authorization, the
auth-bypass regression, the no-plaintext-in-any-response guarantee, and the
partial-update property the UI depends on.

Expand Down
Loading