Conversation
mattv8
commented
Sep 20, 2024
| # Reroute login to yourls filter | ||
| # (see https://github.com/YOURLS/YOURLS/wiki/Advanced-Hook-Syntax) | ||
| //yourls_add_filter( 'is_valid_user', 'ldapauth_is_valid_user' ); | ||
| yourls_add_filter('shunt_is_valid_user', 'ldapauth_is_valid_user'); |
Owner
Author
There was a problem hiding this comment.
NOTE: I need to review the security implications of shunt_is_valid_user before I am comfortable merging this PR.
mattv8
changed the title
mattv8
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated so yourls-ldap-plugin now functions with latest YOURLS version (1.8.1 as of May 24, 2021).
LDAPAUTH_ADD_NEW' flag working again with latest YOURLS config, so users can be cached in the config.