Skip to content

Wait for the connection's lights replay in keypad session tests - #8

Merged
mattt merged 1 commit into
mainfrom
mattt/fix-flaky-clear-test
Nov 14, 2026
Merged

mattt merged 1 commit into
mainfrom
mattt/fix-flaky-clear-test

Conversation

@mattt

@mattt mattt commented Nov 14, 2026

Copy link
Copy Markdown
Owner

No description provided.

After a connection, the session replays the desired lights through the
lighting queue. Tests that waited only for the connection or for layer 4
could start their own lighting calls while that replay was still to come.
In the interrupted-clear test, the replay could take its turn before the
clear and send the zones request that the test held, so the unplug failed
the replay instead of the clear, and the clear returned without an error.

Wait for the work that follows the connection before the tests that set
lights, hold replies, or disconnect the keypad.
@mattt
mattt merged commit 8dc0812 into main Nov 14, 2026
3 checks passed
@mattt
mattt deleted the mattt/fix-flaky-clear-test branch November 14, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant