Repository navigation
Wait for the connection's lights replay in keypad session tests - #8
Merged
Merged
Conversation
After a connection, the session replays the desired lights through the lighting queue. Tests that waited only for the connection or for layer 4 could start their own lighting calls while that replay was still to come. In the interrupted-clear test, the replay could take its turn before the clear and send the zones request that the test held, so the unplug failed the replay instead of the clear, and the clear returned without an error. Wait for the work that follows the connection before the tests that set lights, hold replies, or disconnect the keypad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.