Skip to content

Fix a race that read the keymap twice after a connection - #6

Merged
mattt merged 2 commits into
mainfrom
mattt/fix-flaky-keymap-test
Nov 14, 2026
Merged

mattt merged 2 commits into
mainfrom
mattt/fix-flaky-keymap-test

Conversation

@mattt

@mattt mattt commented Nov 7, 2026

Copy link
Copy Markdown
Owner

No description provided.

mattt added 2 commits November 7, 2026 06:03
A poll that came before the connection's keymap read found no earlier
read and read the keymap too, so the session read it twice within the
refresh interval. The keymap re-read test now polls the session itself
and waits for the connection's work, instead of sleeping.
A repaint that waited for the lighting queue still painted every light
after ChatGPT quit. The ChatGPT lighting tests now wait for the
connection's lighting writes and no longer sleep before counting.
@mattt
mattt merged commit eda1841 into main Nov 14, 2026
3 checks passed
@mattt
mattt deleted the mattt/fix-flaky-keymap-test branch November 14, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant