Fix Dockerfile to handle non-unique GID for macOS compatibility#657
Open
Prajeet-Shrestha wants to merge 1 commit into
Open
Fix Dockerfile to handle non-unique GID for macOS compatibility#657Prajeet-Shrestha wants to merge 1 commit into
Prajeet-Shrestha wants to merge 1 commit into
Conversation
|
@Prajeet-Shrestha is attempting to deploy a commit to the Matt Pocock's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
I've already put up a PR with the same fix: #613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #656
Problem
On macOS, most user belongs to a group which has GID 20. Sandcastle passes this GID to docker build, but inside the node:22-bookworm image, GID 20 is already used by another group, because of that it was causing the issue.
Fix
Added --non-unique to both groupmod and usermod in Dockerfile for all the agents.
Before:
RUN groupmod -g $AGENT_GID node && usermod -u $AGENT_UID -g $AGENT_GID -d /home/agent -m -l agent nodeAfter:
RUN groupmod -g $AGENT_GID --non-unique node && usermod -u $AGENT_UID -g $AGENT_GID -d /home/agent -m -l agent --non-unique node