fix: declare missing @effect/* dependencies#612
Open
hlynurstef wants to merge 2 commits into
Open
Conversation
|
@hlynurstef is attempting to deploy a commit to the Matt Pocock's projects Team on Vercel. A member of the Team first needs to authorize it. |
…ncies Packages required by @effect/platform-node and other effect sub-deps were not declared in sandcastle's own dependencies, causing a hard runtime failure for yarn v1 users (yarn does not auto-install peer dependencies unlike npm v7+). Fixes mattpocock#591 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hlynurstef
force-pushed
the
fix/missing-effect-dependencies
branch
from
a462053 to
673acfe
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@effect/cluster,@effect/experimental,@effect/rpc,@effect/sql, and@effect/typeclassas directdependencies@effect/platform-nodeand other effect sub-packages already listed as dependencies, but were not declared in sandcastle's ownpackage.jsonpackage-lock.jsonto include the new packagesRoot cause
@effect/platform-node(and related packages) declare@effect/cluster,@effect/rpc,@effect/sql, and@effect/typeclassas peer dependencies. npm v7+ silently auto-installs peer dependencies, so this goes unnoticed for npm users. However, yarn v1 does not auto-install peer dependencies, causing a hard runtime failure:The fix is to declare these packages as direct
dependenciesof sandcastle, since they are genuinely required at runtime.Closes #591
🤖 Generated with Claude Code