v1.0.0: bug fixes, cleanup, and modernization#64
Merged
Conversation
Bug fixes: - Fix findall using original iterator instead of collected copy for partitioning (would fail with generators) - Fix findnearest adaptive threshold: compare now reads the atomic min_score so the threshold progressively tightens during search - Remove redundant fetch.() calls in findnearest and findall Breaking changes: - Remove deprecated OptimalStringAlignement binding (use OptimalStringAlignment) - Remove deprecated findmax (use findnearest) Cleanup: - Fix misleading [1] indexing on common_prefix() in JaroWinkler (returns Int, not tuple) - Fix NMD duplicate docstring line - Add comment explaining the max_dist fallback pattern - Fix README: Hamming listed as SemiMetric, actually Metric Modernization: - Bump Julia compat from 1.3 to 1.6 - Update CI to test on Julia 1.6 instead of 1.3 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findallbug: was using original iterator instead of collected copy for partitioning (would fail with generators)findnearestadaptive threshold:comparenow reads the atomicmin_scoreso the threshold progressively tightens during searchfetch.()calls infindnearestandfindallOptimalStringAlignement(4+ years) andfindmax(5+ years)[1]indexing oncommon_prefix()in JaroWinkler, fix NMD duplicate docstring, fix README Hamming typeTest plan
JULIA_NUM_THREADS=4🤖 Generated with Claude Code