Allow you to set pod labels#481
Conversation
Add extraPodLabels
Add values tag
add extraPodLabels
|
Hello @bjorns163, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
/check-cla |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to configure pod labels to support larger deployment environments for Mattermost.
- Introduces an extraPodLabels setting in both team and enterprise edition values files.
- Updates deployment templates in both charts to render the extraPodLabels if provided.
- Note: In the enterprise edition values file, extraPodLabels is defined under mattermostApp, while the corresponding templates reference it at the root.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/mattermost-team-edition/values.yaml | Adds extraPodLabels at the root level for team edition |
| charts/mattermost-team-edition/templates/deployment.yaml | Inserts extraPodLabels into deployment labels |
| charts/mattermost-enterprise-edition/values.yaml | Adds extraPodLabels under mattermostApp for enterprise edition |
| charts/mattermost-enterprise-edition/templates/deployment-mattermost-jobserver.yaml | References extraPodLabels at root (mismatch with values file) |
| charts/mattermost-enterprise-edition/templates/deployment-mattermost-app.yaml | References extraPodLabels at root (mismatch with values file) |
Comments suppressed due to low confidence (2)
charts/mattermost-enterprise-edition/templates/deployment-mattermost-jobserver.yaml:33
- In the enterprise edition, extraPodLabels is defined under 'mattermostApp' in values.yaml. Please update the reference to '.Values.mattermostApp.extraPodLabels' to correctly match the values file.
{{- if .Values.extraPodLabels }}
charts/mattermost-enterprise-edition/templates/deployment-mattermost-app.yaml:34
- In the enterprise edition, extraPodLabels is defined under 'mattermostApp' in values.yaml. Please update the reference to '.Values.mattermostApp.extraPodLabels' to correctly match the values file.
{{- if .Values.extraPodLabels }}
|
@bjorns163 do you know why this hasn't been merged yet? This is a really useful feature! |
|
@stafot Thanks for the review. Do you know in which release this will be available? It seems to be blocked by some checks. |
The current deployment lacks the ability to set pod labels. While this may not directly affect the usage of Mattermost, it is a common feature needed in bigger environments. This adds the ability to set them