Don't require separately built nginx container#30
Draft
mattcen wants to merge 1 commit into
Draft
Conversation
Often when running an nginx container or similar, one might use the upstream container image but override its config by using a volume to bind-mount in a new config file from a local directory. If running `docker compose` targeting a remote host, the bind-mount looks for its source on the remote host, rather than the local, so the sought file doesn't exist. I'd been working around this by building a custom nginx container whose only change was its config. This change instead uses an inline Docker Config object to work around this. I'd tried sourcing the config object from a local file, but this has the same problem as the above, in that it looks for the config source on the remote host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Needs testing before merge
Often when running an nginx container or similar, one might use the
upstream container image but override its config by using a volume to
bind-mount in a new config file from a local directory.
If running
docker composetargeting a remote host, the bind-mountlooks for its source on the remote host, rather than the local, so the
sought file doesn't exist.
I'd been working around this by building a custom nginx container whose
only change was its config.
This change instead uses an inline Docker Config object to work around
this. I'd tried sourcing the config object from a local file, but this
has the same problem as the above, in that it looks for the config
source on the remote host.