Fix docs_pages_workflow PEP 668 failure + gate it on PRs - #201
Merged
Conversation
debian:bookworm (adopted when we moved off EOL debian:buster) marks its system Python as externally managed per PEP 668, so `pip install` into it now fails with 'externally-managed-environment'. Pass --break-system-packages on the two pip calls — this job builds docs in a throwaway container, so system-Python install is fine and keeps sphinx on PATH for buildDocs.sh. Also add a pull_request trigger: this workflow previously ran only on push to main, so its failure slipped past PR #200's checks and only surfaced after merge. Now a broken docs build gates the PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
docs_pages_workflowfailure that surfaced onmainright after #200 merged.Two changes:
debian:bustertodebian:bookworm. Bookworm marks its system Python as externally managed (PEP 668), sopip installinto it now fails witherror: externally-managed-environment. Added--break-system-packagesto the twopipcalls — this job builds docs in a throwaway container, so a system-Python install is fine and keepssphinxonPATHfordocs/buildDocs.sh.pushtomain, so its failure was not among Fix README badges: finish master→main migration and revive CI #200's PR checks and only appeared post-merge. Added apull_request: branches: [main]trigger so a broken docs build blocks the PR going forward.Test plan
pull_requestrun ofdocs_pages_workflowis the live test — it must reach and pass theInstall phipperystep (previously the failure point) ondebian:bookworm.Deviations from spec
None — this is a direct follow-up fix, no separate spec. Chose
--break-system-packagesover a venv becausebuildDocs.shexpectssphinxon the system PATH; a venv would require threading its activation through that script too.🤖 Generated with Claude Code