Add async gens for multiple clans/players#8
Merged
Conversation
I added these methods for: - `get_clan` -> `get_clans` - `get_current_war` -> `get_current_wars` - `get_player` -> `get_players` I think that should be it. I also added examples in the docstrings as well. I figured `collections.Iterable` as a good enough description for people. And the `tags = iter(tags)` enforces that an iterable was passed before we even start iterating just as a check.
Contributor
Author
|
Also added in the helper method here. Refer to #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added these methods for:
get_clan->get_clansget_current_war->get_current_warsget_player->get_playersI think that should be it. I also added examples in the docstrings as well. I figured
collections.Iterableas a good enough description for people. And thetags = iter(tags)enforces that an iterable was passed before we even start iterating just as a check.