fix: DateTime.add/3 :nanosecond precision error#34
Open
ceolinrenato wants to merge 3 commits intomathieuprog:masterfrom
Open
fix: DateTime.add/3 :nanosecond precision error#34ceolinrenato wants to merge 3 commits intomathieuprog:masterfrom
:nanosecond precision error#34ceolinrenato wants to merge 3 commits intomathieuprog:masterfrom
Conversation
Author
|
@mathieuprog 7f2fbb3 generalizes the conversion, but it looks like elixir uses microsecond precision by default and there's no higher precision than nanoseconds. So I'm not sure which solution is better, as not using constants for this could lead into weird behaviours we can revert 7f2fbb3 if you agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
(added a test that reproduces it)