Expose 'languages' so they can be extended outside of the module#31
Open
jazziebgd wants to merge 3 commits intomatheuss:masterfrom
Open
Expose 'languages' so they can be extended outside of the module#31jazziebgd wants to merge 3 commits intomatheuss:masterfrom
jazziebgd wants to merge 3 commits intomatheuss:masterfrom
Conversation
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 90.9% 91.17% +0.26%
==========================================
Files 2 2
Lines 66 68 +2
==========================================
+ Hits 60 62 +2
Misses 6 6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed support for different scripts (i.e. sr-Latn and sr-Cyrl) in my code. Since those couldn't be added, I (slightly) modified the code so language data can be extended once module is required.
Now I can do the following: