Skip to content

Fix #110 (stabilize field tactic)#122

Merged
proux01 merged 1 commit intomath-comp:masterfrom
proux01:fix-110
Sep 15, 2025
Merged

Fix #110 (stabilize field tactic)#122
proux01 merged 1 commit intomath-comp:masterfrom
proux01:fix-110

Conversation

@proux01
Copy link
Copy Markdown
Collaborator

@proux01 proux01 commented Sep 3, 2025

Fix #110

This doesn't work with no_check but no_check doesn't lake much sense in this context anway, as it's essentially meant to be used wrapped in abstract, hence for goal-terminating tactics.

@pi8027
Copy link
Copy Markdown
Member

pi8027 commented Sep 4, 2025

The no_check stuff is there to skip only the check that the reified term indeed evaluates back to the goal. I don't see how this is related to post-processing the proof obligation.

@proux01
Copy link
Copy Markdown
Collaborator Author

proux01 commented Sep 4, 2025

My bad, I confused that with the common abstract/no_check pattern to speed up Qed.
Then, I guess we can do it that way.

@proux01
Copy link
Copy Markdown
Collaborator Author

proux01 commented Sep 4, 2025

The CI error is probably due to some stalled Docker image, not sure there is much we can do about that.

@proux01
Copy link
Copy Markdown
Collaborator Author

proux01 commented Sep 15, 2025

Now that affeldt-aist/infotheo#178 is merged, let's merge (and hope it doesn't break too much reverse dependencies).

@proux01 proux01 merged commit 88aab35 into math-comp:master Sep 15, 2025
5 of 6 checks passed
@proux01 proux01 deleted the fix-110 branch September 15, 2025 12:49
@pi8027
Copy link
Copy Markdown
Member

pi8027 commented Sep 16, 2025

Apery seems broken.

@proux01
Copy link
Copy Markdown
Collaborator Author

proux01 commented Sep 16, 2025

Should be fixed by rocq-community/apery#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize field tactic

2 participants