Adapt to https://github.com/math-comp/math-comp/pull/1448#119
Merged
pi8027 merged 2 commits intomath-comp:masterfrom Aug 25, 2025
Merged
Adapt to https://github.com/math-comp/math-comp/pull/1448#119pi8027 merged 2 commits intomath-comp:masterfrom
pi8027 merged 2 commits intomath-comp:masterfrom
Conversation
9 tasks
pi8027
reviewed
Aug 25, 2025
| @@ -1,3 +1,4 @@ | |||
| From mathcomp Require all_algebra. (* Remove this line when requiring Rocq > 9.1 *) | |||
Member
There was a problem hiding this comment.
Do you really need to import all_algebra first, i.e., not in the dependency order?
Collaborator
Author
There was a problem hiding this comment.
Well, it has to come before any (even transitive) Require that does Declare ML Module micromega, so first is the safest.
Note that it is only a Require, not a Require Import
pi8027
approved these changes
Aug 25, 2025
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to math-comp/math-comp#1448