fix: workflow chain broken — qc silent, release hardcoded, docs over-…#20
Merged
Conversation
Contributor
Ontology Quality CheckROBOT ReportNo issues found — all ROBOT report checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three bugs discovered and verified in production on a downstream fork
(materialdigital/logistics-application-ontology). All three cause silent
failures — no error, just wrong behavior.
Bug 1 — qc.yml: build artifacts never committed (silent failure)
Root cause (two compounding issues):
.gitignorecontainssrc/ontology/log-base.*,src/ontology/log-full.*etc. — ODK default that assumes built artifacts are not tracked. But the
workflow design requires them committed so
release.ymlanddocs.ymlcan find them on the next run.
The EndBug commit step uses a single
git addcall with all globs in onestring. When
src/ontology/*.jsonmatches nothing (ODK does not produceJSON for all ontologies), git exits with
fatal: pathspec did not match any files— aborting the entire staging command. Nothing is staged, soEndBug reports "Working tree clean. Nothing to commit." and succeeds — with
zero files committed.
Effect: Every build silently discards its output.
src/ontology/log-full.owlstays permanently stale.
release.ymlstamps an outdated artifact.docs.ymldocuments the wrong ontology state.Fix:
src/ontology/log-base.*/log-full.*/log-simple.*/log.owl/
log.obo/log.json/log.dbfrom.gitignore— built artifacts mustbe tracked.
git addcall with per-globgit add || trueso onemissing pattern cannot abort the rest.
Bug 2 — release.yml: hardcoded ontology ID and base IRI
The stamp step hardcodes: