Skip to content

Lesson whatever - #340

Open
madsgroenbaek wants to merge 2 commits into
mate-academy:mainfrom
madsgroenbaek:lesson-whatever
Open

madsgroenbaek wants to merge 2 commits into
mate-academy:mainfrom
madsgroenbaek:lesson-whatever

Conversation

@madsgroenbaek

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The test results show that 2 out of 3 tests are failing. The search function is returning 0 results when it should be finding notes that contain the search term. Specifically, the tests "search finds every note that contains the term" (expected 2, got 0) and "search finds a single containing note" (expected 1, got 0) are both failing. The core requirement that all three tests must pass after the fix is not met. Please ensure the search functionality in lib/store.js properly filters notes that contain the search term (case-insensitive) and returns the matching notes array.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants