Repository navigation
Conversation
matches() used strict equality, so only notes whose text exactly equaled the term were returned. Use includes() for substring matching. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mateacademy-ai-mentor
approved these changes
Oct 28, 2026
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution correctly fixes the search bug in the notes tool. The matches function in lib/store.js now uses .includes() for substring matching, which properly finds notes containing a search term rather than requiring an exact match. All three tests pass, and all core functional requirements are met: add, all (list), search, and remove functions are implemented correctly. The implementation is minimal and focused—one line change that addresses the core issue. Great work on fixing this bug!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matches() used strict equality, so only notes whose text exactly equaled the term were returned. Use includes() for substring matching.
All 3 tests pass (npm test).