Repository navigation
Fix search to match notes containing the term - #321
Open
Lemonch1ks wants to merge 1 commit into
Open
Lemonch1ks wants to merge 1 commit into
Lemonch1ks wants to merge 1 commit into
Conversation
The `matches` helper compared each note's text to the search term with strict equality, so `notes search milk` only returned a note whose whole text was exactly "milk". The search command is meant to list every note that contains the term, so "buy milk" and "milk the almonds" were missed. Use `String.prototype.includes` for a substring match instead. This makes the two failing search tests pass; all three tests are green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
matcheshelper compared each note's text to the search term with strict equality, sonotes search milkonly returned a note whose whole text was exactly "milk". The search command is meant to list every note that contains the term, so "buy milk" and "milk the almonds" were missed.Use
String.prototype.includesfor a substring match instead. This makes the two failing search tests pass; all three tests are green.