Update DataFusion rev to 05a6c45 (skip non-join plan rebuild)#44
Merged
Conversation
Picks up upstream DF #21947 (massive-com/arrow-datafusion@05a6c45): EnforceDistribution::adjust_input_keys_ordering no longer returns Transformed::yes for non-join/non-aggregate plans with no key requirements, eliminating an unnecessary tree rebuild per pass. For atlas, this directly cuts physical-optimizer time on plans containing OneOf candidates: the OneOfExec children() trick already exposes only the best candidate, but every adjust_input_keys_ordering call still rebuilt the entire plan tree. With this fix, non-join plans short-circuit early.
There was a problem hiding this comment.
Pull request overview
Updates this crate’s pinned DataFusion git dependencies to pick up an upstream optimizer improvement that avoids unnecessary plan-tree rebuilds during EnforceDistribution::adjust_input_keys_ordering for non-join/non-aggregate plans with no key requirements, reducing physical-optimizer overhead on affected plans.
Changes:
- Bump all
datafusion*git dependencies from rev7768d24to05a6c45.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the DataFusion rev from `7768d24` to `05a6c45`, picking up upstream DF #21947 (`massive-com/arrow-datafusion@05a6c45`):
`EnforceDistribution::adjust_input_keys_ordering` no longer returns `Transformed::yes` for non-join/non-aggregate plans with no key requirements, eliminating an unnecessary tree rebuild per pass.
Why
For atlas, this directly cuts physical-optimizer time on plans containing OneOf candidates. `OneOfExec.children()` already exposes only the best candidate to the tree walker, but every `adjust_input_keys_ordering` call previously rebuilt the entire plan tree regardless. With this fix, non-join plans short-circuit early.
Test plan