Skip to content

Improve API errors #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Leo-Besancon wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Improve API errors #4652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca85b0
Improve readonly behaviour
Leo-Besancon Feb 22, 2024
2ca579c
Merge branch 'main' into improve_api
AurelienFT Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions massa-api/src/public.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,11 @@ impl MassaRpcServer for API<Public> {
fee,
} in reqs
{
if address.is_none() && fee.is_some() {
return Err(
ApiError::BadRequest("fee argument is set without address".into()).into(),
);
}
let address = if let Some(addr) = address {
addr
} else {
Expand Down Expand Up @@ -327,6 +332,12 @@ impl MassaRpcServer for API<Public> {
fee,
} in reqs
{
if caller_address.is_none() && (fee.is_some() || coins.is_some()) {
return Err(ApiError::BadRequest(
"fee or coins argument is set without caller_address".into(),
)
.into());
}
let caller_address = if let Some(addr) = caller_address {
addr
} else {
Expand Down