Skip to content

feat: Add optional RC branch support#212

Open
r-pedraza wants to merge 3 commits into
masterfrom
feat/setup-optional-rc-branch-in-git-plugin
Open

feat: Add optional RC branch support#212
r-pedraza wants to merge 3 commits into
masterfrom
feat/setup-optional-rc-branch-in-git-plugin

Conversation

@r-pedraza

Copy link
Copy Markdown
Contributor

Pull Request

📝 Summary

This PR adds support for an optional release candidate (RC) branch configuration in the Git plugin, allowing users to specify an RC branch prefix.

🔧 Changes Made

  • Added rc_branch parameter to GitClient initialization in git_client.py
  • Updated GitPlugin to pass rc_branch from config in plugin.py
  • Added rc_branch field to GitPluginConfig model in models.py

🧪 Testing

  • Unit tests added/updated (poetry run pytest)
  • All tests passing (make test)
  • Manual testing with titan-dev

📊 Logs

  • No new log events

✅ Checklist

  • Self-review done
  • Follows the project's logging rules (no secrets, no content in logs)
  • New and existing tests pass
  • Documentation updated if needed
  • Plugin documentation updated when plugin functions or parameters changed (Plugins > Git Plugin, GitHub Plugin, Jira Plugin)

@r-pedraza r-pedraza self-assigned this Apr 22, 2026
return v.lower() # Normalize email to lowercase


class TekelPluginConfig(BaseModel):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pydantic model TekelPluginConfig is defined twice in this file, once starting at line 131 and again at line 179. This duplication will likely cause runtime errors and should be removed. It seems to be an accidental copy-paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants