Split connection creation from connection caching in Schema and QueryBuilder#5
Merged
Conversation
…QueryBuilder Ported from MasoniteFramework/orm#959 and MasoniteFramework/orm#961. - new_connection() is now a pure factory: it always creates and returns a fresh connection without storing it, allowing independent connections to be used alongside each other. - get_connection() now owns the cached-connection lifecycle and is used by all internal call sites. - Schema previously recreated its connection before every DDL call, which could exhaust backend connection limits during migrations. - Adds Schema.query_builder() to get a QueryBuilder bound to the same connection settings, useful for arbitrary queries (DDL, SET) during migrations.
…ic change - MSSQLPostProcessor read the last insert id via new_connection(); with new_connection() now returning an independent connection, @@IDENTITY (connection-scoped) would always be NULL. Use the builder's cached connection instead. - Schema.query_builder() referenced self.dry which does not exist on Schema (the attribute is _dry). - Clarify Schema.get_connection() docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Closes #3
What this does
Gives
new_connection()/get_connection()consistent semantics in bothSchemaandQueryBuilder:new_connection()is now a pure factory — it always creates and returns a fresh connection without storing it. This allows independent connections to be used alongside each other (e.g. runningSETstatements or DDL on a separate connection during migrations).get_connection()owns the cached connection and is what all internal call sites now use.Schemapreviously recreated its connection before every DDL call — a single migration with severalschema.xxxcalls opened a new backend connection each time, which can exhaust connection limits during long migration runs. It now reuses one connection.Schema.query_builder()returning aQueryBuilderbound to the same connection settings.Fixes added on top of the original PRs
The original branches had three latent issues, addressed here in a follow-up commit:
MSSQLPostProcessor.process_insert_get_id()still calledbuilder.new_connection(). Under the new semantics that creates an independent connection, andSELECT @@Identityis connection-scoped — the last insert id would always come back NULL on MSSQL. It now usesbuilder.get_connection()(matching whatSQLitePostProcessoralready did).Schema.query_builder()referencedself.dry, which doesn't exist onSchema(the attribute is_dry) — calling it raisedAttributeError."""Create"""docstring onSchema.get_connection().Tests
tests/schema/test_schema.pyandtests/query/test_querybuilder.pycovering: connection caching (same object returned),new_connection()independence (does not replace the cached connection), andSchema.query_builder().test_alter_drop_on_table_schema_tablerequires a live Postgres server — fails identically on3.x).