P1: enable independent multi-IED FAT connections - #147
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 scope
Enable true independent multi-IED connection/monitoring in the IO FAT workspace while deliberately keeping FAT evidence journaling single-active per IED.
What changes
_preparingIedlock; preparation state now belongs to eachIoTestIedPlan;IsPreparingstate;BindIed(...)and use target-scoped live binding throughout FAT preparation so one IED cannot clear or rewrite another IED's binding state at await boundaries;IoTestSessionControllerintentionally single-active and device-filtered so transitions cannot enter the wrong evidence journal.Safety invariants
Regression coverage
Adds
IoFatMultiIedConnectionRegressionTestsfor target-scoped binding isolation, per-IED preparation/action state, source-contract checks for parallel connection UX, and preservation of single-active/device-filtered evidence capture.Please gate merge on focused IO tests, full ARSAS regression tests, portable publish, and smoke test.