Add engine-owned SCL workspace API - #25
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59eb92db90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if (!string.IsNullOrWhiteSpace(pair.Value.DataSetReference) && | ||
| !string.IsNullOrWhiteSpace(observedReport.DataSetReference) && | ||
| !Same(ReferenceTail(pair.Value.DataSetReference), ReferenceTail(observedReport.DataSetReference))) |
There was a problem hiding this comment.
When the observed model comes from LiveIedModelDiscoveryBuilder, report DataSetReference values are normalized from MMS $ separators to dots, while the SCL projection keeps references such as IEDLD0/LLN0$ds. This comparison therefore reports ReportDataSetMismatch for a matching live RCB that has a datSet, causing RequiresFullDiscovery to be true even when the live model matches; normalize both tails to the same separator before calling Same.
Useful? React with 👍 / 👎.
| continue; | ||
| } | ||
|
|
||
| if (pair.Value.MemberCount != observedDataSet.MemberCount) |
There was a problem hiding this comment.
For a live DataSet with the same name and member count but different FCDA members or a different order, this block adds no finding and CompareLive can still return compatible. Reports, GOOSE, and SV interpret values by DataSet member order, so using the design model after this comparison can map live values to the wrong semantic points; compare member references/FCs by index, not only MemberCount.
Useful? React with 👍 / 👎.
| DataSets = parsed.DataSets.Where(x => Same(x.IedName, descriptor.IedName)).ToArray(), | ||
| ReportControls = parsed.ReportControls.Where(x => Same(x.IedName, descriptor.IedName)).ToArray(), | ||
| GooseStreams = parsed.GooseStreams.Where(x => Same(x.IedName, descriptor.IedName)).ToArray(), | ||
| SampledValuesStreams = parsed.SampledValuesStreams.Where(x => Same(x.IedName, descriptor.IedName)).ToArray(), |
There was a problem hiding this comment.
When a single IED has multiple AccessPoints with distinct Server models, each per-AccessPoint workspace gets all parsed DataSets, RCBs, GOOSE, and SV streams for the IED here, even though DesignModel was filtered to descriptor.AccessPointName. An app selecting IED/P1 can therefore display or bind process-bus/report objects that belong only to P2; derive these inventories from the isolated design model or carry the AccessPoint through parsing before filtering.
Useful? React with 👍 / 👎.
|
ArIED integration is now implemented and validated in masarray/arsas#20. The application PR consumes |
1 participant
Summary
SclWorkspaceServicefor opening ICD/CID/IID/SCD/SSD/XML filesConnectedAP/AddressparametersLiveIedModelDiscoveryDocumentper IED and AccessPointWhy
ArIED currently implements a separate application-level SCL endpoint parser and then repeats full MMS discovery. ARIEC61850 already owns SCL semantics and offline model projection, so product applications need one reusable API rather than duplicating protocol parsing.
Application impact
ArIED can replace its
SclImportServicewith this engine API, browse LD/LN/DO/DA offline, retain templates without IP addresses, bind endpoints later, and compare the SCL design model with a live discovery document.Validation
GitHub Actions run .NET CI #131 completed successfully:
The authoring environment did not contain a local .NET SDK; GitHub Actions provided the compiler and test validation gate.