Repository navigation
Cover the plugin manifests and skill frontmatter (stack 4/5) - #45
Closed
martient wants to merge 1 commit into
Conversation
martient
added this pull request to stack #48
September 20, 2026 17:40
AGENTS.md asks for public-seam tests over "machine output, exit codes, Git behavior, hook protocol, and plugin manifests". The first four were covered; nothing compiled or executed the manifests, so a typo in any of the six JSON and Markdown files shipped silently. Nine tests: both marketplace manifests parse and their declared sources resolve to real directories carrying the expected plugin manifest; the Claude and Codex plugin manifests agree on name, version and license; the Codex skills path resolves; skill frontmatter uses only the keys the Agent Skills spec allows and carries the two required ones; a skill's frontmatter name matches its directory; descriptions carry a trigger rather than just a capability; no skill body uses runtime-specific invocation syntax, since that body is shared by Codex and Claude Code; and every skill is reachable from the cross-tool .agents/skills path. Each assertion was mutation-checked -- a bogus frontmatter key and a marketplace source pointing at a missing directory both fail with the message that names the problem.
martient
force-pushed
the
claude/ai-agents-capabilities-report-fgpp3p-manifest-tests
branch
from
September 20, 2026 18:03
683104f to
2a4b19a
Compare
Owner
Author
|
Superseded by #49, which carries these commits unchanged. Closing — see #42 for why the stack was collapsed. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #44. Resolves P1-12.
AGENTS.mdasks for public-seam tests over "machine output, exit codes, Git behavior, hook protocol, and plugin manifests". The first four were covered. Nothing compiled or executed the manifests, so a typo in any of the six JSON and Markdown files shipped silently — the plugin would simply fail to load for a user, with no signal here.Nine tests
Manifests
name,versionandlicense— they describe the same plugin and had no mechanism keeping them in step.skillspath resolves.Skill frontmatter, against the Agent Skills spec
name,description,license,allowed-tools,metadata,compatibility); anything else fails validation in a compliant runtime.namematches its directory, or discovery breaks.Shared-body hygiene
$skill(Codex) or/plugin:skill(Claude Code) syntax. That body is shared by both runtimes, so neither form belongs in it. This is the regression guard for the fix in Make AGENTS.md canonical and reach every runtime (stack 3/5) #44..agents/skills.These were mutation-checked
Tests that pass the moment you write them prove nothing, so I broke the things they guard and confirmed they fail with a message that names the problem:
author:to a skill's frontmatter`author` is not an Agent Skills frontmatter key./plugins/typomarketplace points at `./plugins/typo`, which does not existBoth pass again after restoring.
Verification
fmtclean,clippy -D warningsclean. The pre-existingtag_testsfailure noted in #42 is unchanged.