Repository navigation
feat: postgres, config por variavel de ambiente e migrate no servidor - #32
Merged
Merged
Conversation
3 of 4 tasks
4 tasks done
NicolasArthurDev
approved these changes
Oct 2, 2026
NicolasArthurDev
left a comment
Contributor
There was a problem hiding this comment.
Muito boa a separação, ficou bem mais fácil de revisar! A troca para pgx está limpa, o storagetest com um banco por teste garante isolamento, e a validação de faixa da porta e do tamanho de nota ficou bem feita, com mensagem que mostra o valor recebido. A observação sobre a 00001 editada no lugar na descrição foi um ótimo cuidado. Aprovado.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que mudou
markupp migratemake testroda no host17.9-alpine3.23no compose e nos testesPor quê
Observações
00001foi editada no lugar, trocando TIMESTAMP por TIMESTAMPTZ, sem migração nova. Só é seguro porque ainda não existe banco PostgreSQL de ninguémComo testar
make test(precisa de Go e Docker)make rune os curl da seção Validar do DEPLOY.mdAuto-review (checklist)