Use a more robust check for process completion#1
Open
lbeltrame wants to merge 1 commit into
Open
Conversation
The approach used in the script assumes that the GPU is exclusively used by the invoker. However, some places (like mine) treat GPUs as shared resources. Therefore, the single presence of a process called `python` in the process list, even if not created by the caller, will cause the script to loop needlessly. This change creates an array where the PIDs for each of the calculations are stored, then uses `wait` to ensure that all the processes have ended before moving to the next iteration. **Note**: This adds a dependency on bash (but I'm not sure if this script is POSIX-compatible) and requires a reasonably recent version of it (tested with 5.0 on Debian).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approach used in the script assumes that the GPU is exclusively used
by the invoker. However, some places (like mine) treat GPUs as shared
resources: different users can use the same GPU. Therefore, the single
presence of a process called
pythonin the process list, even if not createdby the caller, will cause the script to loop needlessly without doing anything.
This change creates an array where the PIDs for each of the calculations
are stored (using
$!), then useswaitto ensure that all the processes haveended before moving on to the next iteration.
Note: This adds a dependency on bash (but I'm not sure if this
script is POSIX-compatible) and requires a reasonably recent version of
it (tested with 5.0 on Debian).