Skip to content

docs(halmet): sensor and capability design for the HALMET firmware - #142

Merged
mark-brannan merged 3 commits into
mainfrom
claude/halmet-firmware-sensors-5322fe
Oct 26, 2026
Merged

mark-brannan merged 3 commits into
mainfrom
claude/halmet-firmware-sensors-5322fe

Conversation

@mark-brannan-agent

@mark-brannan-agent mark-brannan-agent Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Adds reference/halmet_firmware.md: what the HALMET measures, the engine/boat point for each sensor, and which HALMET input it uses.

  • Board integration points, from Hat Labs' docs and the HALMET-hardware schematic (rev 1.0.1), including the 2×10 GPIO header J201. The digital inputs and I2C are galvanically isolated; the analog current source tops out at 300 Ω.
  • What firmware/halmet/ does today, with its known gaps (index-addressed probes, −127 °C publishing, alarm.* instead of notifications.*, test pulse on by default).
  • Planned: thermocouple on the dry elbow, more DS18B20 points, IR flame on D4, start-battery and alternator voltage, ignition sense, fuel vacuum, derived run hours / engine state / raw-water-loss alarm.
  • Cooling: a fresh coolant circuit plus raw seawater joining at the mixing elbow (owner's answer, 2026-10-26).
  • Gas sensing (BME688/690, MQ-series) stays on the separate gas-sensor box, per the 2026-09-26 answer recorded in the engine plan.
  • A "Considered and not done" table and an Open list.

Decide

  • The "Considered and not done" rows are Claude's recommendations, except the gas-box and alternator-tach rows (owner's answers, 2026-09-26). Strike any you want kept open.
  • The "read-only on the engine" principle is Claude's draft.

Pencil:

  • Location reference/halmet_firmware.md (design rationale lives in reference/). Undo: git mv.
  • A4 goes to the fuel vacuum or the oil-pressure transducer, whichever is fitted first; water-in-fuel and bilge-pump run take the second ADS1115. Undo: edit two table rows and one sentence.
  • The 110-character table-cell limit is not applied: the rubric that sets it is not in the repo. Undo: reflow the wide rows once it is.

Head: 416bd91

🤖 Generated with Claude Code · claude-sonnet-5-5 · -

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 953ed059-f631-4ba1-ab41-9449994ca102

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Claude finished @mark-brannan-agent[bot]'s task in 1m 4s —— View job


I'll analyze this and get back to you.

@mergify

mergify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Comment thread reference/halmet_firmware.md Outdated
Comment thread reference/halmet_firmware.md Outdated
…input; unsourced engine claims out

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Comment thread reference/halmet_firmware.md Outdated
… item

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@mark-brannan
mark-brannan merged commit 8974dce into main Oct 26, 2026
37 checks passed
@mark-brannan
mark-brannan deleted the claude/halmet-firmware-sensors-5322fe branch October 26, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant