Open
Conversation
# Conflicts: # src/main/java/net/maritimeconnectivity/serviceregistry/controllers/InstanceController.java
Merging changes from MCC fork
# Conflicts: # src/main/java/net/maritimeconnectivity/serviceregistry/models/domain/Instance.java
oliverhaagh
reviewed
Aug 4, 2025
Comment on lines
+102
to
+108
| @Tag(name = "SECOM") | ||
| @Transactional | ||
| @Path(SEARCH_SERVICE_INTERFACE_PATH) | ||
| @POST | ||
| @Consumes(MediaType.APPLICATION_JSON) | ||
| @Produces(MediaType.APPLICATION_JSON) | ||
| public ResponseSearchObject searchService(@Valid SearchFilterObject searchFilterObject) { |
Member
There was a problem hiding this comment.
Would it be possible to also have a GET version of this, as that is required by the specification?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm almost done with SECOMLib for SECOM v2.0 and I added the new library in thsi latest version of the MSR.
This now theoretically supports both version of the SECOM API which you can also see in Swagger.
I haven't yet tested it very well but we can start to make sure everything looks OK.
In terms of changes, both SECOMLib versions had to be updated to support each other. Since this is a temp change, these are left as snapshots in the pom.
Apart from that, I added some OpenAPI configurations and some datetime formatters to deal with the various SECOM v1.0/v2.0 and MIR date formats. Also, one thing I don't like is the data product types which are locked to SECOMv1.0 but they are redefined in v2.0, so we kind of have to switch between the same enum from two libs...