Skip to content

slides config panel by default to open #9737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Light2Dark merged 1 commit into from
Jun 1, 2026
+15 −7
Merged

slides config panel by default to open #9737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const SlidesLayoutRenderer: React.FC<Props> = ({
setLayout={setLayout}
activeIndex={resolvedIndex}
onSlideChange={handleSlideChange}
configWidth={300}
configWidth={280}
mode={isReading ? "read" : mode}
isEditable={!isReading}
/>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/slides/reveal-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ const RevealSlidesComponent = ({
activeIndex,
onSlideChange,
mode,
configWidth = 300, // px
configWidth, // px
isEditable = false,
}: {
cellsWithOutput: RuntimeCell[];
Expand All @@ -240,7 +240,7 @@ const RevealSlidesComponent = ({
activeIndex?: number;
onSlideChange?: (index: number) => void;
mode: AppMode;
configWidth?: number;
configWidth: number;
isEditable?: boolean;
}) => {
const containerRef = useRef<HTMLDivElement>(null);
Expand Down Expand Up @@ -439,7 +439,7 @@ const RevealSlidesComponent = ({
<div className="group relative" style={{ width, height }}>
<Deck
deckRef={deckRef}
className="aspect-video w-full overflow-hidden border rounded bg-background mo-slides-theme prose-slides"
className="aspect-video w-full overflow-hidden border rounded bg-background mo-slides-theme prose-slides focus:outline-none focus-visible:outline-none"
Comment thread
Light2Dark marked this conversation as resolved.
config={revealConfig}
onReady={handleDeckReady}
onSlideChange={handleSlideChange}
Expand Down
14 changes: 11 additions & 3 deletions frontend/src/components/slides/slide-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,23 @@ import type {
SlidesLayout,
SlideType,
} from "../editor/renderers/slides-layout/types";
import { useState } from "react";
import { useAtom } from "jotai";
import { atomWithStorage } from "jotai/utils";
import { Tooltip } from "../ui/tooltip";
import { Button } from "../ui/button";
import { Kbd } from "../ui/kbd";
import type { RuntimeCell } from "@/core/cells/types";
import { jotaiJsonStorage } from "@/utils/storage/jotai";

export const DEFAULT_SLIDE_TYPE: SlideType = "slide";
export const DEFAULT_DECK_TRANSITION: DeckTransition = "slide";
const COLLAPSED_CONFIG_WIDTH = 36;
const slideConfigOpenAtom = atomWithStorage<boolean>(
"marimo:slides:config-open",
true,
jotaiJsonStorage,
{ getOnInit: true },
);

export interface SlideTypeOption {
value: SlideType;
Expand Down Expand Up @@ -322,7 +330,7 @@ export const SlideSidebar = ({
setLayout: (layout: SlidesLayout) => void;
activeConfigCell?: RuntimeCell;
}) => {
const [isConfigOpen, setIsConfigOpen] = useState(false);
const [isConfigOpen, setIsConfigOpen] = useAtom(slideConfigOpenAtom);

return (
<aside
Expand Down Expand Up @@ -350,7 +358,7 @@ export const SlideSidebar = ({
variant="ghost"
size="icon"
className="h-7 w-7 text-muted-foreground hover:text-foreground"
onClick={() => setIsConfigOpen(!isConfigOpen)}
onClick={() => setIsConfigOpen((open) => !open)}
aria-expanded={isConfigOpen}
aria-controls="slide-config-panel"
>
Expand Down
Loading