Repository navigation
Consume the fragment contract from @sphere-pub/node instead of vendoring it - #3
Open
marianoviola wants to merge 2 commits into
Open
marianoviola wants to merge 2 commits into
marianoviola wants to merge 2 commits into
Conversation
…ing it src/contract/ (a copy of the schema and hand-written response types) is gone. The schema is imported from @sphere-pub/node/spec/fragment.schema.json and the types from @sphere-pub/node/contract, both bundled at build time; the plugin still ships as a single self-contained server/index.js with no runtime dependency on the node. A test guards against the vendored copy coming back and checks the bundled schema is the package's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
marianoviola
marked this pull request as ready for review
September 21, 2026 19:50
4 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M1, plugin side. Draft until
@sphere-pub/node@1.1.0is on npm (marianoviola/sphere-node#4): the dev dependency is declared as^1.1.0, and CI/npm cican't resolve it before that. Verified locally against the packed 1.1.0 tarball: typecheck, 31/31 tests, build (schema bundled intoserver/index.jsfromnode_modules/@sphere-pub/node/spec/).src/contract/deleted; imports point at@sphere-pub/node/spec/fragment.schema.jsonand@sphere-pub/node/contract..mcpbis unchanged in shape.tests/contract.test.tsfails if a vendored copy reappears, and checks the bundled schema's$id.To do after 1.1.0 is published:
npm installto refreshpackage-lock.json, then un-draft.🤖 Generated with Claude Code