ci: Add red repro for iOS static-library build break on RN <= 0.83 (glog modulemap) - #1574
Open
mfazekas wants to merge 1 commit into
Open
ci: Add red repro for iOS static-library build break on RN <= 0.83 (glog modulemap)#1574mfazekas wants to merge 1 commit into
mfazekas wants to merge 1 commit into
Conversation
…libraries) Since 0.37.0, plain CocoaPods iOS builds (static libraries, no `use_frameworks!`) fail on React Native <= 0.83 with: glog/logging.h:512:1: error: import of module 'glog.glog.log_severity' appears within namespace 'google' react/debug/react_native_assert.h: error: could not build module 'glog' <unknown>:0: error: could not build Objective-C module 'NitroModules' 0.37.0 added `ReactProp.hpp`, `ViewComponentDescriptor.hpp` and `ViewPropsHolderState.hpp` to `public_header_files`, so they became part of the CocoaPods-generated NitroModules modulemap. Their <react/renderer/*> includes reach <glog/logging.h>, and glog's modulemap on RN <= 0.83 cannot be compiled as a clang module - so every Swift `import NitroModules` fails. RN 0.84+ ships a textual-headers glog modulemap, which is why the example app (and existing CI) cannot see this. This workflow pins the regression: it is red on main and should turn green once the renderer-including headers are hidden from the Swift-facing module.
|
@mfazekas is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red-CI repro for #1573, per the contributing guide — no fix included, the fix is in a separate PR.
Since 0.37.0, plain CocoaPods iOS builds (static libraries, no
use_frameworks!) fail on React Native <= 0.83 with:0.37.0 added
ReactProp.hpp,ViewComponentDescriptor.hppandViewPropsHolderState.hpptopublic_header_files, so they became part of the generatedNitroModulesmodulemap; their<react/renderer/*>includes reach<glog/logging.h>, and glog's modulemap on RN <= 0.83 cannot be compiled as a clang module. RN 0.84+ ships a textual-headers glog modulemap (scripts/ios-configure-glog.sh), which is why the example app and existing CI cannot see this — I verified the example also builds fine with RN built fully from source on its RN 0.85.This adds a workflow that builds the
NitroModulespod target inside a bare React Native 0.80.3 app with static libraries. It is red onmainand turns green with the fix PR (which includes this same workflow as its regression test).