Conversation
Updates the lock file, GitHub Actions versions (actions/checkout, actions/setup-python, astral-sh/setup-uv) and pre-commit hook revisions (ruff-pre-commit) to their latest releases. Fixes a YAML structuring bug in .pre-commit-config.yaml where the ruff-pre-commit repo entry was merged into the pre-commit-hooks entry (missing a leading `-`), silently disabling the check-yaml, end-of-file-fixer and trailing-whitespace hooks. With the bug fixed and the hooks running, applies the resulting end-of-file and trailing-whitespace fixes across the repo. Adds PLR0917 and CPY001 to the ruff ignore list: newly-stabilized rules pulled in by the ruff-pre-commit bump that duplicate an existing wilful ignore (PLR0913) or don't match project convention (no per-file copyright headers). Reorders a Union type hint in a test fixture to satisfy RUF036 and updates the one test asserting on that hint's error-message ordering. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PLjDw8y1qHjbiLdyYZhLoH
maread99
added
dependencies
Claude
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Claude.
Summary
Routine dependency update, per the
dependencies-managementskill.uv(0.8.17 → 0.12.16) and ranuv lock --upgrade,uv exportanduv sync --inexactto bringuv.lock/requirements.txt/ the environment up to date.actions/checkoutv6 → v7,actions/setup-pythonv6 → v7,astral-sh/setup-uvv8.1.0 → v10.1.0 (in bothbuild-test.ymlandrelease.yml).ruff-pre-commitv0.15.11 → v0.16.8 (pre-commit-hookswas already at the latest v6.0.0).Bug fix found along the way
.pre-commit-config.yamlhad a YAML structuring bug: theruff-pre-commitrepo entry was missing its leading-, so it merged into thepre-commit-hooksentry as duplicate keys instead of starting a new list item. This silently dropped thecheck-yaml,end-of-file-fixerandtrailing-whitespacehooks — onlyruff-check/ruff-formatwere ever actually running. Fixed the list structure, which caused those hooks to run for the first time and fix pre-existing missing-final-newline / trailing-whitespace issues across several repo files (.claude/settings.json, workflow files,.gitignore,AGENTS.md,LICENSE.txt,pyproject.toml,pytest.ini).Revisions to support the new dependency versions
The
ruff-pre-commitbump pulled in newly-stabilized ruff rules that fired repo-wide once the hook was actually enforced:CPY001(missing copyright notice) andPLR0917(too many positional arguments) — added toruff.toml's ignore list, since the project doesn't use per-file copyright headers and already wilfully ignores the equivalentPLR0913.RUF036(Nonenot at the end of a type union) — fixed by reordering aUnionin a test fixture (tests/test_valimp.py), which is a purely cosmetic change with no effect onvalimp's own union-validation logic (order-independent). Updated the one test that asserted on that hint's error-message text to match the new order.ruff-pre-commitalso now formats Python code fences embedded in Markdown (README.md), which reformatted the README's example code blocks.Notes
mypy src/valimp/reports 12 pre-existing errors unrelated to this dependency update (confirmed identical before and after, viagit stash) — left untouched as out of scope for this PR.uv run pytest -v) passes: 36/36.pre-commit run --all-filespasses cleanly.Test plan
uv run pytest -v— 36 passeduv run pre-commit run --all-files— all hooks pass🤖 Generated with Claude Code
https://claude.ai/code/session_01PLjDw8y1qHjbiLdyYZhLoH