Fix self-contained build: ship as zip (fixes ARM64 crash)#16
Merged
Conversation
WPF's native DLLs (PresentationNative, wpfgfx, D3DCompiler, PenImc, vcruntime140) cannot be embedded in a PublishSingleFile bundle; they are emitted beside the exe. The workflow previously uploaded only the bare standalone exe, so it crashed on launch with DllNotFoundException — badly on ARM64 (reported in #15), and on x64 too once downloaded without the DLLs. Publish the self-contained build as a normal folder and ship it as a zip (exe + native DLLs together). Framework-dependent single-file is unaffected: it gets the native libs from the installed .NET Desktop Runtime. Closes #15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
WPF native DLLs can't be embedded in a single-file bundle, so the bare standalone exe crashed with DllNotFoundException (ARM64 reported by @talynone; x64 affected too once downloaded without the DLLs).
Self-contained now publishes as a folder and ships as a zip (exe + native DLLs together). Framework-dependent single-file is unchanged.