Skip to content

Avoid lazy initialization of Mutex #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olleolleolle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid lazy initialization of Mutex #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/cxxproject/ide_interface.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ def initialize()
@socket = nil
@abort = false
@thread = nil
end

def mutex
@mutex ||= Mutex.new
@mutex = Mutex.new
end

def connect(port)
Expand Down Expand Up @@ -114,7 +111,7 @@ def set_errors(error_array)
msg.message.rstrip!
packet = create_error_packet(msg)
begin
mutex.synchronize { @socket.write(packet) }
@mutex.synchronize { @socket.write(packet) }
rescue Exception => e
Printer.printError "Error: #{e.message}"
set_abort(true)
Expand Down Expand Up @@ -162,7 +159,7 @@ def set_build_info(name_attr, config_name_attr, num = -1)
write_long(packet, num >=0 ? num : 0)

begin
mutex.synchronize { @socket.write(packet) if @socket }
@mutex.synchronize { @socket.write(packet) if @socket }
rescue Exception => e
Printer.printError "Error: #{e.message}"
set_abort(true)
Expand Down