Abstracting AMP validators and sanitizers into AMP Library#4
Open
marcelovani wants to merge 18 commits into
Open
Abstracting AMP validators and sanitizers into AMP Library#4marcelovani wants to merge 18 commits into
marcelovani wants to merge 18 commits into
Conversation
marcelovani
commented
Dec 5, 2018
| readme: { | ||
| command: './dev-lib/generate-markdown-readme' // Generate the readme.md. | ||
| command: './vendor/xwp/wp-dev-lib/generate-markdown-readme' // Generate the readme.md. | ||
| }, |
Owner
Author
There was a problem hiding this comment.
The submodule is now pulled via composer and goes to the vendor folder
marcelovani
commented
Dec 5, 2018
| add_action( 'admin_notices', '_amp_incorrect_plugin_slug_admin_notice' ); | ||
| } | ||
|
|
||
| require_once AMP__DIR__ . '/vendor/autoload.php'; |
marcelovani
commented
Dec 5, 2018
| # create database | ||
| mysqladmin create $DB_NAME --user="$DB_USER" --password="$DB_PASS"$EXTRA | ||
| mysql --user="$DB_USER" --password="$DB_PASS"$EXTRA -e"DROP DATABASE IF EXISTS $DB_NAME" | ||
| mysql --user="$DB_USER" --password="$DB_PASS"$EXTRA -e"create DATABASE $DB_NAME" |
Owner
Author
There was a problem hiding this comment.
Deletes the database if it already exists then re-creates it
marcelovani
commented
Dec 5, 2018
| }, | ||
| { | ||
| "type": "vcs", | ||
| "url": "git@github.com:dennisinteractive/amp-library.git" |
Owner
Author
There was a problem hiding this comment.
Using our fork of amp-library, see pr dennisinteractive/amp-library#6
marcelovani
commented
Dec 6, 2018
| "sabberworm/php-css-parser": "dev-master" | ||
| "sabberworm/php-css-parser": "dev-master as 8.0.0", | ||
| "xwp/wp-dev-lib": "dev-master", | ||
| "lullabot/amp": "dev-amphtml-generator" |
Owner
Author
There was a problem hiding this comment.
Xp-dev-lib is now being cloned with composer
Use fork of lullabot library
marcelovani
commented
Dec 6, 2018
| 'AMP_Options_Menu_Page' => 'includes/options/views/class-amp-options-menu-page', | ||
| 'AMP_Rule_Spec' => 'includes/sanitizers/class-amp-rule-spec', | ||
| 'AMP_Allowed_Tags_Generated' => 'includes/sanitizers/class-amp-allowed-tags-generated', | ||
| // 'AMP_Allowed_Tags_Generated' => 'includes/sanitizers/class-amp-allowed-tags-generated', |
Owner
Author
There was a problem hiding this comment.
This file is being moved to the amp-library https://github.com/dennisinteractive/amp-library/tree/amphtml-generator/src/Spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this pull request I did the following: