chore: Alphabetize contract addresses in active network files#273
chore: Alphabetize contract addresses in active network files#273michaelsmueller wants to merge 4 commits into
Conversation
📝 WalkthroughWalkthroughAddress string literals across four network address configuration files (mainnet-dev, mainnet-prod, sepolia-dev, sepolia-prod) were updated to checksummed/mixed-case hex formats. A new ChangesAddress map checksum updates and PoolDeployerV400 addition
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
jdrskr
left a comment
There was a problem hiding this comment.
LGTM.
One thing to keep in mind is that strict string comparison might break for integrators but I wouldn't expect it to be used like this
|
you mean because we use checksum case rather than lowercase? |
Problem
Address entries in the network files weren't alphabetized (e.g.
PoolDeployerV400sat betweenPoolManagerV400andPoolPermissionManager), and address values were inconsistently cased — mostly EIP-55 checksummed on mainnet but overwhelmingly all-lowercase on sepolia.Solution
Two mechanical passes over the four active network files (
mainnet-prod,mainnet-dev,sepolia-prod,sepolia-dev):manifestkept last).Verified: same 173-key set in every file, and each address is byte-identical to
mainaside from casing. No invalid/corrupt checksums existed.Other notes
base-mainnet-prodleft untouched (already had no lowercase addresses).MapleStrategyAave/Basic/Sky/Bitcoin grouping (MapleBitcoinStrategy*now sorts under "MapleB"). Say the word if you'd rather preserve that grouping.Summary by CodeRabbit
PoolDeployerV400address across supported networks.