fix(node-layer): Fixes file upload handling#504
Open
mothershipper wants to merge 1 commit intomapbox:mainfrom
Open
fix(node-layer): Fixes file upload handling#504mothershipper wants to merge 1 commit intomapbox:mainfrom
mothershipper wants to merge 1 commit intomapbox:mainfrom
Conversation
PR mapbox#479 attempted to fix requests where the body was null/undefined by setting the GOT body to an empty string - however, this wiped out the body being set by the file handling cases before this logic. This commit adds a check to confirm that gotBody is falsy before setting it to an empty string, preserving the file body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #479 attempted to fix requests where the body was null/undefined by setting the GOT body to an empty string - however, this wiped out the body being set by the file handling cases before this logic.
This commit adds a check to confirm that gotBody is falsy before setting it to an empty string, preserving the file body.
Fixes #486