Obtém IP pelo core do Mapas Culturais (header de proxy configurável)#22
Open
lucasfullstackdev wants to merge 7 commits into
Open
Obtém IP pelo core do Mapas Culturais (header de proxy configurável)#22lucasfullstackdev wants to merge 7 commits into
lucasfullstackdev wants to merge 7 commits into
Conversation
fix: adicionando header da cloudflare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
O core do Mapas Culturais passou a permitir que infra/devops definam qual cabeçalho HTTP deve ser usado para obter o IP do cliente atrás de proxy (Cloudflare, nginx, load balancer, etc.), via
PROXY_HEADERe o ajuste emRequest::getIp()descrito no PR #3615 do mapasculturais. Com isso, o IP deixa de depender só deREMOTE_ADDRe segue a mesma regra do middleware RKA / request PSR-7 no core.Cenário
Em requisições HTTP, o IP gravado na auditoria (MapasBlame) precisa ser o mesmo que o restante da aplicação usa — ou seja, o que
Request::getIp()do core resolve após o #3615, e não uma leitura paralela de$_SERVERno plugin.Implementação
MapasBlame\Request: o IP vem direto de$app->request->getIp()(comentário no código remete à request PSR-7), mantendo o blame alinhado ao core e ao header configurável emPROXY_HEADER.MapasBlame\Plugin: oRequestdeixa de ser criado no_init()e passa a ser instanciado na primeira requisição que dispara os hooks de rota (holder lazy), para só acessar$app->requestquando o ciclo HTTP já estiver montado. O hookentity(<<*>>).remove:aftersegue registrando delete comnew Request()dentro do callback, sem depender de instância criada cedo no_init().