-
Notifications
You must be signed in to change notification settings - Fork 2
draft: implement hs visualizer #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
250854c
feat: add hitsound visualizer
maotovisk e05a0ab
feat(hs_visualizer): implement new timeline view
maotovisk 9d18fe2
feat: add ManagedBass playback service and playback runner for audio …
maotovisk ec6d3c0
feat(hitsound): refactor playback handling and improve timing debug i…
maotovisk 55046e7
feat(audio): add audio output device selection and update volume sett…
maotovisk 3917565
feat(hs_visualizer): optimize sample change handling and improve cach…
maotovisk 7457d89
feat(hs_visualizer): enhance timeline interaction with sample change …
maotovisk 7b1e1b3
feat(hs_visualizer): refine tick rendering logic for improved density…
maotovisk 297322c
feat(hs_visualizer): enhance sample handling and visual representatio…
maotovisk 169a82e
fix(hs_visualizer): update row height
maotovisk d37a137
chore: remove dotsettings.user
maotovisk edbddbd
Merge branch 'main' into prototype/hitsound-visualizer
maotovisk b4a88b6
feat: better dropdown
maotovisk fc85b48
Merge branch 'main' into prototype/hitsound-visualizer
maotovisk 3cf6890
feat: add undo/redo functionality
maotovisk 6b30b69
feat: better audio playback and volume controls
maotovisk 080ff81
feat: better playback cursor seeking and tick visualization
maotovisk e8de177
feat: fix audio stuff, add sample index and volume overrides to HitSo…
maotovisk 985fe8c
feat: fix sample index and volume override normalization
maotovisk bc4037f
feat: update playback buttons
maotovisk 309a18b
feat: better hitsound playback and improve playback buffer settings
maotovisk 61fc81d
refactor: simplify managed BASS playback logic and remove unused sett…
maotovisk 0cc7cfb
refactor: reorganize namespaces for services
maotovisk 6a0cc1e
fix: use AsSpan instead of substring
maotovisk 77d1ea9
Merge branch 'main' into prototype/hitsound-visualizer
maotovisk 5e344ca
feat(hitsound_visualizer): add support for destination beatmap select…
maotovisk 4ca2c4f
fix: seeking backwards with scrolling
maotovisk 1c930cf
feat(hitsound_visualizer): add mouse wheel volume adjustment for song…
maotovisk ca90951
feat(hitsound_visualizer): better hitsound parsing and selection mech…
maotovisk aec432b
fix(beatmap_selection_panel): remove potential memleak
maotovisk 66d2269
feat(song_library): add library reload functionality and cache invali…
maotovisk 5977b3c
chore(dependencies): update package versions including `MapWizard.Bea…
maotovisk f39d843
fix: bounds clicks on the timeline to external element in order to ge…
maotovisk 5474c78
feat(logging): introduce `MapWizardLogger` for exception logging with…
maotovisk 35eb242
chore(logging): integrate `MapWizardLogger` exception logging into va…
maotovisk aeda829
chore(logging): refine `MapWizardLogger` usage and clean up redundant…
maotovisk 10183b0
chore(hitsound_service): add tolerance constants for snap tick genera…
maotovisk 29231df
chore(song_library): enhance cache invalidation to handle concurrent …
maotovisk 3f13e13
feat(settings): add support for toggling HitSound Visualizer feature …
maotovisk c47aaf7
feat(beatmap_selection): add a way to quick change the selected diff …
maotovisk 183cc32
feat(hitsound_visualizer): improve playback position preservation and…
maotovisk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ output.osu | |
| .idea | ||
| .vscode | ||
| .dotnet-home/ | ||
| /MapWizard.sln.DotSettings.user | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| namespace MapWizard.Desktop.Enums; | ||
|
|
||
| public enum ResultStatus | ||
| { | ||
| Success, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundTimelineContextRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundTimelineContextRequest | ||
| { | ||
| public int TimeMs { get; set; } | ||
| public int PointId { get; set; } = -1; | ||
| public int? SampleChangeTimeMs { get; set; } | ||
| public bool IsSampleRow { get; set; } | ||
| } |
7 changes: 7 additions & 0 deletions
7
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundTimelineRowAddRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundTimelineRowAddRequest | ||
| { | ||
| public int TimeMs { get; set; } | ||
| public int RowIndex { get; set; } | ||
| } |
7 changes: 7 additions & 0 deletions
7
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundTimelineZoomRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundTimelineZoomRequest | ||
| { | ||
| public int AnchorTimeMs { get; set; } | ||
| public double ZoomFactor { get; set; } = 1d; | ||
| } |
20 changes: 20 additions & 0 deletions
20
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundVisualizerDocument.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using System.Collections.Generic; | ||
| using MapWizard.Tools.HitSounds.Timeline; | ||
|
|
||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundVisualizerDocument | ||
| { | ||
| public string BeatmapPath { get; set; } = string.Empty; | ||
| public string MapsetDirectoryPath { get; set; } = string.Empty; | ||
| public string AudioFilePath { get; set; } = string.Empty; | ||
| public string DisplayTitle { get; set; } = string.Empty; | ||
| public double EndTimeMs { get; set; } | ||
|
|
||
| // Export-compatible working structure used by the hitsound copier. | ||
| public HitSoundTimeline Timeline { get; set; } = new(); | ||
|
|
||
| public IReadOnlyList<HitSoundVisualizerPoint> Points { get; set; } = []; | ||
| public IReadOnlyList<HitSoundVisualizerSampleChange> SampleChanges { get; set; } = []; | ||
| public IReadOnlyList<HitSoundVisualizerSnapTick> SnapTicks { get; set; } = []; | ||
| } |
15 changes: 15 additions & 0 deletions
15
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundVisualizerPoint.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| using BeatmapParser.Enums; | ||
|
|
||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundVisualizerPoint | ||
| { | ||
| public int Id { get; set; } | ||
| public int TimeMs { get; set; } | ||
| public SampleSet SampleSet { get; set; } = SampleSet.Normal; | ||
| public int? SampleIndexOverride { get; set; } | ||
| public int? SampleVolumeOverridePercent { get; set; } | ||
| public bool IsAutoSampleSet { get; set; } | ||
| public HitSound HitSound { get; set; } = HitSound.Normal; | ||
| public bool IsDraggable { get; set; } | ||
| } |
11 changes: 11 additions & 0 deletions
11
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundVisualizerSampleChange.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| using BeatmapParser.Enums; | ||
|
|
||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundVisualizerSampleChange | ||
| { | ||
| public int TimeMs { get; set; } | ||
| public SampleSet SampleSet { get; set; } = SampleSet.Normal; | ||
| public int Index { get; set; } | ||
| public int Volume { get; set; } | ||
| } |
11 changes: 11 additions & 0 deletions
11
MapWizard.Desktop/Models/HitSoundVisualizer/HitSoundVisualizerSnapTick.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| namespace MapWizard.Desktop.Models.HitSoundVisualizer; | ||
|
|
||
| public class HitSoundVisualizerSnapTick | ||
| { | ||
| public int TimeMs { get; set; } | ||
| public double ExactTimeMs { get; set; } | ||
| public string Label { get; set; } = string.Empty; | ||
| public int Strength { get; set; } | ||
| public int Denominator { get; set; } | ||
| public bool IsMeasureLine { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| using MapWizard.Desktop.Enums; | ||
|
|
||
| namespace MapWizard.Desktop.Models; | ||
|
|
||
| public class Result<T> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
MapWizard.Desktop/Models/Settings/AudioOutputDeviceOption.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| namespace MapWizard.Desktop.Models.Settings; | ||
|
|
||
| public sealed class AudioOutputDeviceOption | ||
| { | ||
| public AudioOutputDeviceOption(string id, string displayName, bool isDefault, bool isEnabled) | ||
| { | ||
| Id = id; | ||
| DisplayName = displayName; | ||
| IsDefault = isDefault; | ||
| IsEnabled = isEnabled; | ||
| } | ||
|
|
||
| public string Id { get; } | ||
|
|
||
| public string DisplayName { get; } | ||
|
|
||
| public bool IsDefault { get; } | ||
|
|
||
| public bool IsEnabled { get; } | ||
|
|
||
| public override string ToString() => DisplayName; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.