Conversation
Calc dir drainage rebase See merge request brgm/codes-hydrogeologiques/others/gridmarthe!2
river network See merge request brgm/codes-hydrogeologiques/others/gridmarthe!3
- bad file path in one test from previous commit: reverted - change paths for river network - add back modifs in conventions lost in rebase Co-authored-by: Shuaitao Wang <s.wang@brgm.fr>
add/fix: read grids with bad metadata without cleanmgrid See merge request brgm/codes-hydrogeologiques/others/gridmarthe!4
- change the default behavious of get_active_mask, to return an array of cell ids that can be used as a mask, or optionnally the filtered array. See #13 Old behaviour can still be obtained with options. - expose func to parse dims from attrs for users.
…ttern in get_dims_from_attrs in _parse_gridmarthe module
Fix tests suite issues due to incorrect import and wrong pattern See merge request brgm/hydrogeological-modelling/marthe-tools/gridmarthe!5
Fix: read_rma regex for multi-line support See merge request brgm/hydrogeological-modelling/marthe-tools/gridmarthe!6
…ames (#17) When a .rma file is passed as a bare filename (e.g. 'myproject.rma'), os.path.dirname() returns an empty string, causing incorrect path resolution in the .layer file lookup. This fix uses os.path.abspath() to normalize the path before extracting the directory, and replaces string formatting with os.path.join() for robustness. Also adds a regression test that verifies read_files_from_rma works correctly when called with a bare filename from a temporary directory. Assisted by Claude Code
Fix FileNotFoundError in read_files_from_rma with relative paths See merge request brgm/hydrogeological-modelling/marthe-tools/gridmarthe!8
this change fix compatibility between standard name `missing_value` in variable attrs and automatically added `_FillValue` from xarray.to_netcdf. Close #16
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.