Skip to content

closes #3: add windows version for transport/tcp.go#5

Closed
5amu wants to merge 1 commit intomandiant:mainfrom
5amu:windows-build
Closed

closes #3: add windows version for transport/tcp.go#5
5amu wants to merge 1 commit intomandiant:mainfrom
5amu:windows-build

Conversation

@5amu
Copy link
Copy Markdown

@5amu 5amu commented Apr 21, 2026

The _windows.go file is compiled only when GOOS=windows and does not depend on CGO. It relies exclusively on Go’s standard library and supports proxy configuration via environment variables.

I performed basic testing, although I do not yet have a dedicated lab environment. The implementation follows the same approach I used in a previous pet project (https://github.com/5amu/goad). I'm revisiting it to use this library and start developing it again, so thank you for that!

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 21, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

the _windows.go file will compile only when GOOS=windows and does not rely on CGO. It uses default go libraries and is proxy aware (from env)
@psycep
Copy link
Copy Markdown
Collaborator

psycep commented Apr 22, 2026

Hey @5amu thanks for opening this, the _windows.go split using x/net/proxy.Dial was the right call. I ended up going a bit wider with #10, which covers the same Windows unblock plus an explicit -proxy flag, UDP handling, and chaining with proxychains. The build tag there is !cgo || windows so CGO_ENABLED=0 Linux also builds, which yours couldn't hit because _unix.go still required cgo. Keeping this one open for now, once #10 lands I'll close it and link the merge commit. If you want to take a look at #10 or have feedback on the approach, please do. Thanks again!

@psycep
Copy link
Copy Markdown
Collaborator

psycep commented Apr 22, 2026

Closing as landed in #10 (merge commit 8f997a5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants