security: reject ACE with AceSize below minimum header size#24
Open
Jah-yee wants to merge 1 commit intomandiant:mainfrom
Open
security: reject ACE with AceSize below minimum header size#24Jah-yee wants to merge 1 commit intomandiant:mainfrom
Jah-yee wants to merge 1 commit intomandiant:mainfrom
Conversation
When AceSize is less than 8, the fixed 4-byte header plus 4-byte Mask are not contained in the ACE. The existing len(data) < aceSize check passes (len(data) may be >= 8) but later slices like data[4:8] and data[offset:aceSize] panic with 'slice bounds out of range'. Fixes mandiant#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When AceSize is less than 8, the fixed 4-byte header plus 4-byte Mask are not contained in the ACE. The existing check passes (len(data) may be >= 8) but later slices like and panic with 'slice bounds out of range'.
This adds a simple bounds check: if , return an error immediately after reading the AceSize field.
Fixes #23